Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: change the default timeout of JSONConnection.api_request() to non-None #10217

Closed
plamut opened this issue Jan 28, 2020 · 0 comments · Fixed by #10219
Closed

Core: change the default timeout of JSONConnection.api_request() to non-None #10217

plamut opened this issue Jan 28, 2020 · 0 comments · Fixed by #10219
Assignees
@plamut
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link
Contributor

plamut commented Jan 28, 2020

As discussed offline - a None default timeout can cause requests to hang indefinitely, which is especially problematic in libraries that do not provide any reasonable means of overriding that timeout.

In order to avoid bugs resulting from that, the current default needs to be changed.
@plamut plamut added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: core labels Jan 28, 2020
@plamut plamut self-assigned this Jan 28, 2020
@plamut plamut mentioned this issue Jan 28, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): change default api_request() timeout to non-None plamut/google-cloud-python
1 participant
@plamut