Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code branch test coverage #1993

Closed
daspecster opened this issue Jul 18, 2016 · 5 comments
Closed

Code branch test coverage #1993

daspecster opened this issue Jul 18, 2016 · 5 comments
Assignees
@tseaver
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daspecster
Copy link
Contributor

So since merging #1876, the hooks don't seem to be working. I'm not sure if it's us or codecov.io at this point.

Also since we ran into this being an issue again...

I'm proposing that we just have travis-ci fail on tox -e cover.
@daspecster daspecster added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 18, 2016
@dhermes
Copy link
Contributor

dhermes commented Jul 18, 2016

Seems wasteful, since we'll want the fancy badge to show we are cool and responsible.

@daspecster
Copy link
Contributor Author

Could have travis-fail + coveralls. Then we would be cool and truly responsible ;)

@dhermes
Copy link
Contributor

dhermes commented Jul 18, 2016

Yeah I know, I'm just being grumble grumble

@daspecster
Copy link
Contributor Author

daspecster commented Jul 18, 2016 •
edited
Loading

I feel ya, I wish codecov just worked. Or for that matter I wish coveralls...covered all...

@tseaver
Copy link
Contributor

tseaver commented Aug 25, 2016

Via #2103.

@tseaver tseaver closed this as completed Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daspecster @tseaver @dhermes