Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Let bqstorage_client authentication errors be raised in to_dataframe #7661

Closed
tswast opened this issue Apr 4, 2019 · 1 comment
Closed

BigQuery: Let bqstorage_client authentication errors be raised in to_dataframe #7661

tswast opened this issue Apr 4, 2019 · 1 comment
Assignees
@tswast
Labels
api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Contributor

tswast commented Apr 4, 2019

Now that I'm trying to write a tutorial on using the BigQuery Storage API to download query results, I've had a change of heart regarding whether to_dataframe should fall back to the tabledata.list API when there are authentication errors. Originally, I thought we should fallback on authentication errors, but now I see that it hides problems.

Someone could have downloaded the right libraries but either don't have the right permissions or haven't enabled the API, but those errors will be swallowed. Instead, downloading large tables will be much slower than expected.
@tswast tswast added api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 4, 2019
@tswast tswast mentioned this issue Apr 4, 2019
Merged
@tswast tswast added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 5, 2019
@tswast
Copy link
Contributor Author

tswast commented Apr 5, 2019

I think this is worthy of being a bug. I consider it a "known issue" for to_dataframe that authorization errors can be swallowed.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 5, 2019
@tswast tswast self-assigned this Apr 5, 2019
@tswast tswast added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Apr 5, 2019
@tswast tswast mentioned this issue Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tswast @yoshi-automation