Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Make the Retry objects complete "exactly" at deadline #9872

Closed
plamut opened this issue Nov 21, 2019 · 0 comments · Fixed by #9873
Closed

Core: Make the Retry objects complete "exactly" at deadline #9872

plamut opened this issue Nov 21, 2019 · 0 comments · Fixed by #9873
Assignees
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link
Contributor

plamut commented Nov 21, 2019

In the current implementation, the Retry instances only check if the next delay (sleep period) happens before the deadline. If the next sleep period is long compared to the remaining time, the last retry can happen "long" after the specified deadline, which can be undesired in certain scenarios.

As an API Core user I would like to have an option to mark the deadline as strict, making the Retry object to complete retrying (approximately) at the deadline, not beyond.

@plamut plamut added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: core labels Nov 21, 2019
@plamut plamut changed the title Core: Allow configuring Retry objects to complete "exactly" at deadline Core: Make the Retry objects complete "exactly" at deadline Dec 9, 2019
@plamut plamut self-assigned this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant