Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to google.cloud.spanner_v1 #4064

Merged
merged 8 commits into from
Sep 26, 2017
Merged

Move to google.cloud.spanner_v1 #4064

merged 8 commits into from
Sep 26, 2017

Conversation

lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Sep 26, 2017 •
edited
Loading

Uses #4028 as a base.

This PR moves to a google.cloud.spanner_v1 canonical namespace with google.cloud.spanner aliasing its exports.

  • Move the code.
    • Address the types collision by making a google.cloud.spanner_v1.param_types module.
  • Update docstrings.
  • Update .rst files.
  • Update unit tests.
  • Update system tests.

Luke Sneeringer added 5 commits September 25, 2017 15:34
WIP
453fe08
Update all the Spanner imports.
9d80700 
  * `google.cloud.spanner` becomes `google.cloud.spanner_v1`
  * New alias at `google.cloud.spanner`.
Update docstrings.
cf7ce5e
Move RST docs to g.c.spanner_v1.
618e574
Merge branch 'spanner-beta' into spanner_v1_alias
bba6b08
@lukesneeringer lukesneeringer added api: spanner Issues related to the Spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 26, 2017
@lukesneeringer lukesneeringer added this to the Spanner Beta milestone Sep 26, 2017
@lukesneeringer lukesneeringer self-assigned this Sep 26, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2017
@lukesneeringer
Copy link
Contributor Author

Removing the do not merge label; tests now pass and docs build.
The one system test that always fails on creating a new instance is still failing on creating a new instance.

@lukesneeringer lukesneeringer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2017
@lukesneeringer lukesneeringer mentioned this pull request Sep 26, 2017
Merged
7 tasks
@lukesneeringer lukesneeringer merged commit bdae20d into spanner-beta Sep 26, 2017
@lukesneeringer lukesneeringer deleted the spanner_v1_alias branch September 26, 2017 17:26
lukesneeringer added a commit that referenced this pull request Sep 26, 2017
@lukesneeringer
Move to google.cloud.spanner_v1 (#4064)
716c2f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees

@lukesneeringer lukesneeringer

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukesneeringer @theacodes @googlebot