From 9bc46c493dae83cd7d4a16ee0f59d60c4c593ad8 Mon Sep 17 00:00:00 2001 From: Tres Seaver Date: Mon, 6 Apr 2015 17:34:04 -0400 Subject: [PATCH] Don't pass 'fields' query parm to subscription GET. Work around #799 (leaving open while @tmatsuo investigates). --- gcloud/pubsub/subscription.py | 4 +--- gcloud/pubsub/test_subscription.py | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gcloud/pubsub/subscription.py b/gcloud/pubsub/subscription.py index 2fab37924ea6..3d59e9ffa2d6 100644 --- a/gcloud/pubsub/subscription.py +++ b/gcloud/pubsub/subscription.py @@ -74,9 +74,7 @@ def exists(self): """ conn = self.topic.connection try: - conn.api_request(method='GET', - path=self.path, - query_params={'fields': 'name'}) + conn.api_request(method='GET', path=self.path) except NotFound: return False else: diff --git a/gcloud/pubsub/test_subscription.py b/gcloud/pubsub/test_subscription.py index eb5145cd989d..e7c5c654ddd2 100644 --- a/gcloud/pubsub/test_subscription.py +++ b/gcloud/pubsub/test_subscription.py @@ -95,7 +95,7 @@ def test_exists_miss(self): req = conn._requested[0] self.assertEqual(req['method'], 'GET') self.assertEqual(req['path'], '/%s' % SUB_PATH) - self.assertEqual(req['query_params'], {'fields': 'name'}) + self.assertEqual(req.get('query_params'), None) def test_exists_hit(self): PROJECT = 'PROJECT' @@ -111,7 +111,7 @@ def test_exists_hit(self): req = conn._requested[0] self.assertEqual(req['method'], 'GET') self.assertEqual(req['path'], '/%s' % SUB_PATH) - self.assertEqual(req['query_params'], {'fields': 'name'}) + self.assertEqual(req.get('query_params'), None) def test_reload(self): PROJECT = 'PROJECT'