Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for FileSetSpec #2888

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: Add support for FileSetSpec #2888

merged 2 commits into from
Sep 25, 2023
+64 −4

Conversation

emkornfield
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ x ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x ] Ensure the tests and linter pass
  • [ x] Code coverage does not decrease (if any source code was changed)
  • [ x ] Appropriate docs were updated (if necessary)

Fixes #2830 ☕️

@emkornfield emkornfield requested a review from a team as a code owner September 19, 2023 07:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Sep 19, 2023
@emkornfield
Copy link
Contributor Author

@shollyman is there someone else I should tag for review?

@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2023
@Neenu1995 Neenu1995 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner September 21, 2023 14:24
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2023
@obada-ab obada-ab added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Sep 25, 2023
@obada-ab
Copy link
Member

merge-on-green bot doesn't seem to work, merging manually

@obada-ab obada-ab merged commit 3895bd9 into googleapis:main Sep 25, 2023
14 checks passed
@release-please release-please bot mentioned this pull request Sep 27, 2023
Merged
This was referenced Oct 3, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Manifest FileSetSpecType to External Table Configuration
3 participants
@emkornfield @obada-ab @Neenu1995