-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): Update schema for broken ConnImplBenchmark test #3574
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@alvarowolfx Could you please help with the review and performance evaluation? |
@alvarowolfx, did you have a chance to look into it? |
@PhongChuong can you take a look on this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Lets discuss the slow read results in further in #2764.
/gcbrun |
Thanks for the reply. You probably mean googleapis/java-bigquerystorage#2764 |
I'm trying to use the
executeSelect
API and faced extremely slow reading.I tried to use
ConnImplBenchmark
but noticed that the Shema was changed, and the test didn't work.bigquery-public-data.new_york_taxi_trips.tlc_yellow_trips_2017
Summary of Changes
Added Fields: airport_fee, data_file_year, data_file_month.
Removed Fields: dropoff_longitude, dropoff_latitude, pickup_longitude, pickup_latitude.
After fixing the test I can confirm that we have similar speed results for our use cases.
Reading 100_000 rows takes ~15-20 seconds, which is extremely slow.
I'm not sure if there was any performance degradation recently since I can't find any expected numbers. It's hard to read this benchmark: https://cloud.google.com/blog/topics/developers-practitioners/introducing-executeselect-client-library-method-and-how-use-it/
According to this image, reading of 1_000_000 rows should take ~1sec
That's what I've got on my machine:
I've opened an issue: googleapis/java-bigquerystorage#2764