Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Follow-up CLI Improvements #2184

Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat: Follow-up CLI Improvements #2184

merged 2 commits into from
Aug 30, 2023

Conversation

sydney-munro
Copy link
Collaborator

  1. Rename Workload1.java to W1R3 to prevent future confusion when it is used for other workloads
  2. Take in temporary directory as a CLI argument
  3. Utilize PrintWrite instead of System.out directly

@sydney-munro
feat: Follow-up CLI Improvements
45cbdb8 
1. Rename Workload1.java to W1R3 to prevent future confusion when it is used for other workloads
2. Take in temporary directory as a CLI argument
3. Utilize PrintWrite instead of System.out directly
@sydney-munro sydney-munro requested a review from a team as a code owner August 29, 2023 22:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Aug 29, 2023
BenWhitehead
BenWhitehead approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after enabling autoFlush on the PrintWriter

...arking/src/main/java/com/google/cloud/storage/benchmarking/StorageSharedBenchmarkingCli.java Outdated Show resolved Hide resolved
storage-shared-benchmarking/src/main/java/com/google/cloud/storage/benchmarking/W1R3.java Outdated Show resolved Hide resolved
@sydney-munro sydney-munro added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit d985976 into main Aug 30, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the cli-followup branch August 30, 2023 21:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
@release-please release-please bot mentioned this pull request Aug 30, 2023
Merged
@lucymcnatt lucymcnatt mentioned this pull request Sep 29, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-munro @BenWhitehead