feat: enable open telemetry metrics for GRPC #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
JesseLovelace
added
the
do not merge
BenWhitehead
requested changes
Jun 18, 2024
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITGrpcTest.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/ITGrpcMetricsTest.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/ITGrpcMetricsTest.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
|
Warning: This pull request is touching the following templated files:
|
BenWhitehead
requested changes
Jul 23, 2024
...le-cloud-storage/src/main/java/com/google/cloud/storage/OpenTelemetryBootstrappingUtils.java
Outdated
Show resolved
Hide resolved
...le-cloud-storage/src/main/java/com/google/cloud/storage/OpenTelemetryBootstrappingUtils.java
Outdated
Show resolved
Hide resolved
JesseLovelace
removed
the
do not merge
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
force-pushed
the
grpc-otel-metrics
branch
from
7fb1b20
to
25c6469
Compare
BenWhitehead
requested changes
Jul 29, 2024
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables open telemetry metrics for GRPC
Note: Currently, this emits the metrics with a "generic_task" mapping. In the future, there will be a "gcs_client" mapping supported, with more relevant attributes. We'll need to switch to that when it's available, so I've left in comments to uncomment when we make that switch