Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat: deferred client initialization #12

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

alexander-fenster
Copy link
Contributor

This PR includes changes from googleapis/gapic-generator-typescript#317
that will move the asynchronous initialization and authentication from the client constructor
to an initialize() method. This method will be automatically called when the first RPC call
is performed.

The client library usage has not changed, there is no need to update any code.

If you want to make sure the client is authenticated before the first RPC call, you can do

await client.initialize();

manually before calling any client method.

@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #12 into master will decrease coverage by 90.79%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #12      +/-   ##
========================================
- Coverage   90.79%     0%   -90.8%     
========================================
  Files           4      4              
  Lines        2053   2127      +74     
  Branches       88      0      -88     
========================================
- Hits         1864      0    -1864     
- Misses        187   2127    +1940     
+ Partials        2      0       -2
Impacted Files Coverage Δ
src/v1/cloud_billing_client.ts 0% <0%> (-91.36%) ⬇️
src/v1/cloud_catalog_client.ts 0% <0%> (-88.98%) ⬇️
src/v1/index.ts 0% <0%> (-100%) ⬇️
src/index.ts 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c884b9f...d8cfea2. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 63c6abf into master Mar 6, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants