-
Notifications
You must be signed in to change notification settings - Fork 113
feat: adding ability to specify firewall network #150
Conversation
package.json
Outdated
@@ -51,7 +51,7 @@ | |||
"greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>" | |||
], | |||
"scripts": { | |||
"cover": "nyc --reporter=lcov mocha test/*.js && nyc report", | |||
"cover": "nyc --reporter=lcov mocha test/*$MATCH*.js && nyc report", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thank you, it all looks good to me! Regarding the $MATCH pattern, that change would have to be made upstream in a generator library we use. Let's not hang this PR on it, but @JustinBeckwith-- do we want something like that? |
Also, could you run |
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 19
Lines ? 1581
Branches ? 0
=======================================
Hits ? 1581
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
test/firewall.js
Outdated
var metadata = {network: 'custom-network'}; | ||
|
||
firewall.request = function(reqOpts) { | ||
assert.strictEqual(reqOpts.method, 'PATCH'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
49ef086
to
4496918
Compare
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
68ce9fe
to
1f869fd
Compare
1f869fd
to
00b62a5
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@JustinBeckwith cla help, please! |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Fixes #125
Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
added possibility to specify non-default network for setMetadata firewall method