Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: adding ability to specify firewall network #150

Merged
merged 4 commits into from
Dec 21, 2018

Conversation

apankratov
Copy link
Contributor

@apankratov apankratov commented Sep 5, 2018

Fixes #125

  • Tests and linter pass

  • Code coverage does not decrease (if any source code was changed)

  • Appropriate docs were updated (if necessary)

  • added possibility to specify non-default network for setMetadata firewall method

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 5, 2018
package.json Outdated
@@ -51,7 +51,7 @@
"greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>"
],
"scripts": {
"cover": "nyc --reporter=lcov mocha test/*.js && nyc report",
"cover": "nyc --reporter=lcov mocha test/*$MATCH*.js && nyc report",

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor

Thank you, it all looks good to me!

Regarding the $MATCH pattern, that change would have to be made upstream in a generator library we use. Let's not hang this PR on it, but @JustinBeckwith-- do we want something like that?

@stephenplusplus
Copy link
Contributor

Also, could you run npm run prettier? That should auto-correct the linting failures: https://circleci.com/gh/googleapis/nodejs-compute/4000

@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@45aa29c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #150   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     19           
  Lines             ?   1581           
  Branches          ?      0           
=======================================
  Hits              ?   1581           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/firewall.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45aa29c...f20ceee. Read the comment docs.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 5, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 5, 2018
test/firewall.js Outdated
var metadata = {network: 'custom-network'};

firewall.request = function(reqOpts) {
assert.strictEqual(reqOpts.method, 'PATCH');

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@ghost ghost assigned JustinBeckwith Sep 5, 2018
@ghost ghost assigned fhinkel Oct 12, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 29, 2018
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 2, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 21, 2018
@stephenplusplus stephenplusplus force-pushed the master branch 2 times, most recently from 68ce9fe to 1f869fd Compare November 21, 2018 16:08
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@stephenplusplus
Copy link
Contributor

@JustinBeckwith cla help, please!

@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 21, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 21, 2018
@JustinBeckwith JustinBeckwith changed the title adding ability to specify firewall network feat: adding ability to specify firewall network Dec 21, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 21, 2018
@JustinBeckwith JustinBeckwith merged commit b824c6a into googleapis:master Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants