Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: update root url to compute.googleapis.com #349

Merged
merged 8 commits into from
Sep 10, 2019
Merged

fix: update root url to compute.googleapis.com #349

merged 8 commits into from
Sep 10, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Sep 6, 2019

This change will update the root url used for requests from www.googleapis.com to compute.googleapis.com.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2019
@JustinBeckwith JustinBeckwith requested a review from bcoe September 6, 2019 18:14
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2019
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing due to a few assertions that don't take into account compute:

      AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 'https://www.googleapis.com/compute/v1/zones/us-central1-a/machineTypes/n1-standard-2'
+ 'https://compute.googleapis.com/compute/v1/zones/us-central1-a/machineTypes/n1-standard-2'
      + expected - actual

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          20       20           
  Lines        1524     1524           
=======================================
  Hits         1511     1511           
  Misses         13       13
Impacted Files Coverage Δ
src/service.js 100% <100%> (ø) ⬆️
src/vm.js 97.48% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f87a3b...817bf2e. Read the comment docs.

test/vm.js Outdated Show resolved Hide resolved
test/service.js Outdated Show resolved Hide resolved
test/service.js Outdated Show resolved Hide resolved
src/vm.js Outdated
@@ -249,7 +249,7 @@ class VM extends common.ServiceObject {
this.hasActiveWaiters = false;
this.waiters = [];
this.url = format('{base}/{project}/zones/{zone}/instances/{name}', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for the benefit of a public API, so that the user can view the url of the resource that the VM is based on:

    it('should localize the URL of the VM', function() {
      assert.strictEqual(
        vm.url,
        [
          'https://www.googleapis.com/compute/v1/projects',
          COMPUTE.projectId,
          'zones',
          ZONE.name,
          'instances',
          VM_NAME,
        ].join('/')
      );
    });

@bcoe bcoe merged commit 4ad52a3 into master Sep 10, 2019
@bcoe bcoe deleted the split branch September 10, 2019 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants