This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: correct engines range to include node v10 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`">10"` range does not include the v10 version, it forces v11 and up. Switching to `">=10"` to include v10 (still LTS), which I believe was the original intent (changelog: "require node 10 in engines field")
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 20 20
Lines 11727 11727
=======================================
Hits 11704 11704
Misses 23 23 Continue to review full report at Codecov.
|
|
Woops! Thanks! |
stephenplusplus
approved these changes
Jun 14, 2020
stephenplusplus
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
JustinBeckwith
approved these changes
Jun 16, 2020
JustinBeckwith
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
stephenplusplus
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
">10"` range does not include the v10 version (currently still LTS), it eforces v11 and up.
Switching to
">=10"to include v10, which I believe was the original intent (changelog: "require node 10 in engines field")Fixes #450 🦕