Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: Adding implementation of startWithEncryptionKey api call #539

Merged
merged 7 commits into from
Jun 29, 2021
Merged

Conversation

akowalsk
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #538 🦕

@akowalsk akowalsk requested a review from a team as a code owner January 15, 2021 02:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/nodejs-compute API. label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #539 (984f111) into master (7119ace) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 984f111 differs from pull request most recent head 4ba4ba0. Consider uploading reports for the commit 4ba4ba0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          22       22           
  Lines       11948    11996   +48     
=======================================
+ Hits        11902    11950   +48     
  Misses         46       46           
Impacted Files Coverage Δ
src/vm.js 99.61% <100.00%> (+0.01%) ⬆️
src/zone.js 100.00% <0.00%> (ø)
src/image.js 100.00% <0.00%> (ø)
src/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a4026...4ba4ba0. Read the comment docs.

@akowalsk akowalsk changed the title feat[vm]: Adding implementation of startWithEncryptionKey api call feat: Adding implementation of startWithEncryptionKey api call Jan 15, 2021
@bcoe bcoe requested a review from stephenplusplus January 27, 2021 01:23
@SurferJeffAtGoogle SurferJeffAtGoogle added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle merged commit f8018a6 into googleapis:master Jun 29, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/nodejs-compute API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add startWithEncryptionKey method to vm
5 participants