This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: handle parameters to image.create() #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: compute
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 22 22
Lines 11944 11948 +4
=======================================
+ Hits 11898 11902 +4
Misses 46 46
Continue to review full report at Codecov.
|
bcoe
approved these changes
Jan 27, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27) ### Bug Fixes * handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540
image.create()accepts one too many parameters for whatServiceObject.create()was designed to support. This PR adds a newcreate()method to bypass it.