Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Eliminate constructor pattern #63

Closed
JustinBeckwith opened this issue Apr 12, 2018 · 0 comments
Closed

Eliminate constructor pattern #63

JustinBeckwith opened this issue Apr 12, 2018 · 0 comments
Assignees
Labels
api: compute Issues related to the googleapis/nodejs-compute API. Breaking Change 🚨 This issue needs some love. triage me I really want to be triaged.
Milestone

Comments

@JustinBeckwith
Copy link
Contributor

In index.js we use this pattern:

function Compute(options) {
  if (!(this instanceof Compute)) {
    return new Compute(options);
  }

This will break us as we move to TypeScript, and we need to clean it up.

@JustinBeckwith JustinBeckwith added this to the 0.11 milestone Apr 12, 2018
@ghost ghost removed the type: enhancement label Jun 12, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: compute Issues related to the googleapis/nodejs-compute API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/nodejs-compute API. Breaking Change 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants