This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
feat: add back v3beta1 API surface #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: dialogflow
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 98.53% 98.56% +0.03%
==========================================
Files 16 28 +12
Lines 25256 47846 +22590
Branches 593 1163 +570
==========================================
+ Hits 24885 47158 +22273
- Misses 359 665 +306
- Partials 12 23 +11
Continue to review full report at Codecov.
|
AVaksman
approved these changes
Nov 25, 2020
bcoe
commented
Nov 25, 2020
| @@ -46,7 +46,8 @@ | |||
| "prelint": "cd samples; npm link ../; npm i", | |||
| "prepare": "npm run compile-protos && npm run compile", | |||
| "system-test": "c8 mocha build/system-test", | |||
| "test": "c8 mocha build/test", | |||
| "test": "c8 npm run test:all", | |||
There was a problem hiding this comment.
running both the v1 and v1beta1 tests at the same time results in an OOM issue.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/nodejs-dialogflow-cx/compare/v2.0.0...v2.1.0) (2020-11-25) ### Features * add back v3beta1 API surface ([#39](https://www.github.com/googleapis/nodejs-dialogflow-cx/issues/39)) ([36ba8fa](https://www.github.com/googleapis/nodejs-dialogflow-cx/commit/36ba8fa857ae34a21ce0710986689667f909349f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back v3beta1 API surface.