Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split v1 and v1beta1 protos to improve startup time #1664

Merged
merged 10 commits into from
Jan 21, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jan 20, 2022
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you run synthtool or the owl bot to preview that the new version still compiles after this change?

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@schmidt-sebastian schmidt-sebastian merged commit f3729cf into main Jan 21, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/splitprotos branch January 21, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants