Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integration testing for postgres dialect #1593

Merged
merged 12 commits into from
Apr 3, 2022
Merged

feat: integration testing for postgres dialect #1593

merged 12 commits into from
Apr 3, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners March 25, 2022 09:10
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Mar 25, 2022
@chingor13 chingor13 closed this Mar 25, 2022
@chingor13 chingor13 reopened this Mar 25, 2022
@chingor13 chingor13 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@olavloite olavloite changed the title feat: integration testing for postgres diealect feat: integration testing for postgres dialect Mar 30, 2022
olavloite
olavloite approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM (with a couple of nits)

This will add a lot of additional integration tests, which means that the build time will increase. Is there any indication on how much?

system-test/spanner.ts Outdated Show resolved Hide resolved
system-test/spanner.ts Show resolved Hide resolved
system-test/spanner.ts Outdated Show resolved Hide resolved
system-test/spanner.ts Outdated Show resolved Hide resolved
system-test/spanner.ts Outdated Show resolved Hide resolved
@asthamohta asthamohta requested review from olavloite and a team March 30, 2022 09:24
@asthamohta
Copy link
Contributor Author

Changes LGTM (with a couple of nits)

This will add a lot of additional integration tests, which means that the build time will increase. Is there any indication on how much?

Haven't looked into that but for golang we are skipping backup tests. What do you think?

@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@olavloite
Copy link
Contributor

Changes LGTM (with a couple of nits)
This will add a lot of additional integration tests, which means that the build time will increase. Is there any indication on how much?

Haven't looked into that but for golang we are skipping backup tests. What do you think?

I think that it would be good to skip backup tests for PostgreSQL. I don't think they add enough value to justify the additional build time (the last successful build with all the tests in this PR was 52 minutes, I think)

@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2022
@asthamohta asthamohta merged commit ebe06a6 into googleapis:main Apr 3, 2022
@release-please release-please bot mentioned this pull request Apr 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite Awaiting requested review from olavloite

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asthamohta @olavloite @chingor13