-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration testing for postgres dialect #1593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM (with a couple of nits)
This will add a lot of additional integration tests, which means that the build time will increase. Is there any indication on how much?
Haven't looked into that but for golang we are skipping backup tests. What do you think? |
I think that it would be good to skip backup tests for PostgreSQL. I don't think they add enough value to justify the additional build time (the last successful build with all the tests in this PR was 52 minutes, I think) |
No description provided.