-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow files in directories to be downloaded onto local machine #2199
Conversation
@ddelgrosso1 , I tried running Is that accurate? |
Also, I would like to add a test to check that the files are truly downloaded into the |
That is accurate. I wouldn't worry about running these on your own, they get run in the CI pipeline each time a commit is pushed. However, unit tests should work without issue locally.
If you feel up to it a unit test can probably be created to test this. I can look to see if we have any similar tests elsewhere that might serve as a guide. One thing I will do is to cleanup the the JS Docs to make it abundantly clear that not supplying a |
…nloadManyFiles to File.download
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2200 🦕