-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove extraneous mime-types package in favor of mime #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: storage
Issues related to the googleapis/nodejs-storage API.
labels
Apr 4, 2024
ddelgrosso1
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 4, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 4, 2024
danielbankhead
approved these changes
Apr 4, 2024
Going to add the additional logic to remove |
ddelgrosso1
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Apr 5, 2024
ddelgrosso1
force-pushed
the
remove-mime-type
branch
from
April 8, 2024 21:27
c2ed0a3
to
5812958
Compare
ddelgrosso1
added
owlbot:run
Add this label to trigger the Owlbot post processor.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Apr 8, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 8, 2024
Added additional logic and removed compressible from the dependencies. |
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Apr 8, 2024
ddelgrosso1
force-pushed
the
remove-mime-type
branch
from
April 15, 2024 13:52
8511038
to
3d5e2a3
Compare
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: m
Pull request size is medium.
labels
Apr 15, 2024
ddelgrosso1
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 15, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 15, 2024
danielbankhead
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment
ddelgrosso1
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 15, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 15, 2024
This was referenced Sep 3, 2024
This was referenced Sep 12, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2152 🦕