File.from picks up incorrect bucket name from passed URL

[IchordeDionysos]

I'm going crazy here, as I'm exactly replicating the test case: https://github.com/googleapis/nodejs-storage/pull/2432/files#diff-84c67ae7b647502a4aa36d73e488640768b074793ad0b8c940a22af156e96f0b
And there it worked.

The test also did run: https://github.com/googleapis/nodejs-storage/actions/runs/8440365167/job/23117068589?pr=2432#step:8:689

Though for me the bucket name is always gs ...

When running the regex in the browser it is clear why the issue exists:

The bucket name is at index [0][2] but here it's accessed by index [0][1]

(though I don't understand why the test wouldn't have caught it)

Environment details

• OS: macOS
• Node.js version: v20.11.0
• npm version: 10.2.4
• @google-cloud/storage version: 7.10.1

Steps to reproduce

1. Run npx gts init (use defaults)
2. Run npm i @google-cloud/storage
3. Run npm i ts-node
4. Add the following script: "start": "ts-node ./src/index.ts",
5. Change the src/index.ts to:

import {Storage, File} from '@google-cloud/storage';

const file = File.from(
  'gs://mybucket/myfile',
  new Storage({
    projectId: 'simpleclub',
  })
);
console.log(file.bucket.name); // 'gs'

6. Run using npm run start

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

[IchordeDionysos]

/cc @ddelgrosso1 maybe you have some idea why this is happening for me 🤔

[ddelgrosso1]

Hi @IchordeDionysos I just want to confirm something, are you running this from a browser based application or from a node environment (you mentioned Node 20.11.0)?

[ddelgrosso1]

I see the problem. I will get a fix in ASAP.