-
Notifications
You must be signed in to change notification settings - Fork 120
fix: hybrid glossary tutorial region tag #334
Conversation
…translate into hybrid_glossaries_fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bcoe any brilliant ideas as to why this timeout keeps happening? I didn't change anything related to that test |
@leahecole to me this seems like an issue with gRPC-js, might be worth looping in @alexander-fenster. |
For me it looks like a real timeout happens elsewhere - maybe when working with GCS bucket. Does it repro locally? |
@alexander-fenster testing locally, running the sample seems to hang indefinitely on the line where we |
I will try it locally and see what happens. |
Keep me posted, @alexander-fenster! I can run it locally successfully. If you want to debug together or show me whatever magic you're trying, feel free to send me a calendar invite |
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 3 3
=====================================
Hits 3 3 Continue to review full report at Codecov.
|
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕