Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

fix: hybrid glossary tutorial region tag #334

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Conversation

leahecole
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2019
@leahecole leahecole requested a review from nnegrey September 30, 2019 18:25
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@leahecole
Copy link
Contributor Author

@bcoe any brilliant ideas as to why this timeout keeps happening? I didn't change anything related to that test

@bcoe
Copy link
Contributor

bcoe commented Sep 30, 2019

@leahecole to me this seems like an issue with gRPC-js, might be worth looping in @alexander-fenster.

@alexander-fenster
Copy link
Contributor

For me it looks like a real timeout happens elsewhere - maybe when working with GCS bucket. Does it repro locally?

@bcoe
Copy link
Contributor

bcoe commented Oct 1, 2019

@alexander-fenster testing locally, running the sample seems to hang indefinitely on the line where we await the operation.promise().

@alexander-fenster
Copy link
Contributor

I will try it locally and see what happens.

@leahecole
Copy link
Contributor Author

Keep me posted, @alexander-fenster! I can run it locally successfully. If you want to debug together or show me whatever magic you're trying, feel free to send me a calendar invite

@bcoe bcoe added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #334   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           3      3           
=====================================
  Hits            3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a84bf...205c3cd. Read the comment docs.

@leahecole leahecole merged commit d61836d into master Oct 1, 2019
@leahecole leahecole deleted the hybrid_glossaries_fix branch October 1, 2019 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants