Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

docs: add samples for Measurement Protocol Secrets management methods #152

Merged
merged 31 commits into from
Oct 19, 2021
Merged

docs: add samples for Measurement Protocol Secrets management methods #152

merged 31 commits into from
Oct 19, 2021

Conversation

ikuleshov
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

ikuleshov and others added 20 commits September 1, 2021 17:51
@ikuleshov
update test configuration
f787a04
@parthea
remove custom noxfile configs for now
79093d1
@parthea
remove MaximumUserAccess rom sample
8f1f957
@parthea
add comment in noxfile_config.py
b674e0d
@parthea
run blacken session
de94a95
@parthea
lint
761d8aa
@parthea
add pytest
ee91693
@parthea
Merge branch 'main' into master
6cfcf4f
@ikuleshov
Merge branch 'main' into master
f12b2b1
@ikuleshov
Update noxfile_config.py
7a7c6d2
@ikuleshov
Update noxfile_config.py
9366fdc
@ikuleshov
Merge remote-tracking branch 'upstream/main'
a3e4f17
@ikuleshov
Merge remote-tracking branch 'origin/master'
7de1885 
# Conflicts:
#	samples/noxfile.py
@ikuleshov
delete enhanced measurement settings samples as this functionality is…
a88d15e 
… no longer supported in v1alpha
@ikuleshov
fix the samples tests
e76ba96
@ikuleshov
do not use the maximum_user_access field and update operation in …
3836b72 
…properties.firebase_links tests as this is no longer supported in v1alpha
@ikuleshov
use creator_email_address instead of email_address field in prope…
d235358 
…rties.google_ads_links_list() test as the field has been renamed in v1alpha
@ikuleshov
fix the samples test
d5b923a
@ikuleshov
Merge remote-tracking branch 'upstream/main'
f3d6fa7 
# Conflicts:
#	samples/accounts_search_change_history_events_test.py
@ikuleshov
add samples for Measurement Protocol Secrets management methods
f7c0cd6
@ikuleshov ikuleshov requested a review from a team as a code owner October 13, 2021 05:29
@ikuleshov ikuleshov requested a review from nicain October 13, 2021 05:29
@product-auto-label product-auto-label bot added api: analyticsadmin Issues related to the googleapis/python-analytics-admin API. samples Issues that are directly related to samples. labels Oct 13, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 13, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 15 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 13, 2021
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

2 similar comments
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@parthea
Copy link
Contributor

parthea commented Oct 13, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 13, 2021
parthea
parthea suggested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add observation in sample for deleting measurement protocol secrets, otherwise LGTM.

samples/properties_web_data_streams_measurement_protocol_secrets_delete.py Outdated Show resolved Hide resolved
samples/properties_web_data_streams_measurement_protocol_secrets_delete.py Outdated Show resolved Hide resolved
samples/properties_web_data_streams_measurement_protocol_secrets_delete.py Outdated Show resolved Hide resolved
samples/properties_web_data_streams_measurement_protocol_secrets_delete.py Outdated Show resolved Hide resolved
samples/properties_web_data_streams_measurement_protocol_secrets_delete.py Outdated Show resolved Hide resolved
samples/properties_web_data_streams_measurement_protocol_secrets_delete.py Outdated Show resolved Hide resolved
ikuleshov and others added 7 commits October 19, 2021 03:54
@ikuleshov
Merge branch 'main' into mp_secrets
4937c3f
@ikuleshov @parthea
Update samples/properties_web_data_streams_measurement_protocol_secre…
5b10eef 
…ts_delete.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ikuleshov @parthea
Update samples/properties_web_data_streams_measurement_protocol_secre…
267033a 
…ts_delete.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ikuleshov @parthea
Update samples/properties_web_data_streams_measurement_protocol_secre…
e30b7ca 
…ts_delete.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ikuleshov @parthea
Update samples/properties_web_data_streams_measurement_protocol_secre…
9d674e0 
…ts_delete.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ikuleshov @parthea
Update samples/properties_web_data_streams_measurement_protocol_secre…
505fdc5 
…ts_delete.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ikuleshov @parthea
Update samples/properties_web_data_streams_measurement_protocol_secre…
53ff7fe 
…ts_delete.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ikuleshov ikuleshov requested a review from parthea October 19, 2021 08:02
@ikuleshov
Copy link
Contributor Author

@parthea Thanks for spotting the mangled sample!

@parthea parthea merged commit e264571 into googleapis:main Oct 19, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 19, 2021
@release-please
chore: release 0.7.1 (#155)
b52c971 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.7.1](https://www.github.com/googleapis/python-analytics-admin/compare/v0.7.0...v0.7.1) (2021-10-19)


### Documentation

* **samples:** add samples for Measurement Protocol Secrets management methods ([#152](https://www.github.com/googleapis/python-analytics-admin/issues/152)) ([e264571](https://www.github.com/googleapis/python-analytics-admin/commit/e2645719d6fc518857f64482c48f60e1e0963fc7))
* **samples:** add samples for Conversion Event management methods ([#153](https://www.github.com/googleapis/python-analytics-admin/issues/153)) ([126f271](https://www.github.com/googleapis/python-analytics-admin/commit/126f2711c9fdedaa7cddfe8b3c7bdaff03d0297e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diminishedprime diminishedprime diminishedprime approved these changes

@parthea parthea parthea approved these changes

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-owners

Assignees

@ikuleshov ikuleshov

Labels
api: analyticsadmin Issues related to the googleapis/python-analytics-admin API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikuleshov @parthea @diminishedprime