feat: allow credentials files to be passed for channel creation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
busunkim96
changed the title
…hon-api-core into creds-and-scope-overrides
Merged
5 tasks
busunkim96
commented
Jun 16, 2020
| @@ -218,7 +227,7 @@ def _create_composite_credentials(credentials=None, scopes=None, ssl_credentials | |||
| ) | |||
|
|
|||
|
|
|||
| def create_channel(target, credentials=None, scopes=None, ssl_credentials=None, **kwargs): | |||
| def create_channel(target, credentials=None, scopes=None, ssl_credentials=None, credentials_file=None, **kwargs): | |||
There was a problem hiding this comment.
I added credentials_file to the end of the list to avoid breaking anyone who is using positional arguments.
busunkim96
changed the title
software-dov
approved these changes
Jun 18, 2020
| credentials=mock.sentinel.credentials | ||
| ) | ||
|
|
||
| assert "mutually exclusive" in str(excinfo.value) |
There was a problem hiding this comment.
I'm not a huge fan of checking for explicit strings in exception messages. If it's easy and within the style guides of the repo, I like to make one-off exception types and check for the specific exception type within tests, something like
class DuplicateCredentialArgs(Exception):
pass
...
with pytest.raises(DuplicateCredentialArgs) as exc:
...…hon-api-core into creds-and-scope-overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow credentials files to be passed to
create_channel.For googleapis/gapic-generator-python#432
While it's possible for the library transport to create a credentials object and pass it to
create_channel, I think it will be easier in the long run for the auth logic to remain in_create_composite_credentials.