-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add google.api_core.version_header #638
Conversation
c4498a7
to
cbe0bb1
Compare
578b720
to
ad08619
Compare
93ef5e9
to
7b84e34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
google/api_core/version_header.py
Outdated
|
||
|
||
def to_api_version_header(version_identifier): | ||
"""Returns the API Version header for the given `version_identifier`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's not the header itself, but the data for the header....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 60b33e6
/cherry-pick v1 |
* feat: add google.api_core.gapic_v1.version_header * fix mypy * clarify comment
Towards b/330968465