feat: depend on pydata-google-auth to fetch credentials #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the credentials are not set, the user will be guided through the OAuth flow.
product-auto-label
bot
added
size: s
If the credentials are not set, the user will be guided through the OAuth flow.
sycai
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
changed the title
tswast
requested changes
Aug 27, 2024
| @@ -36,6 +36,7 @@ | |||
| "packaging >= 20.0.0", | |||
| "pandas>=1.1.0", | |||
| "pyarrow >= 3.0.0", | |||
| "pydata-google-auth >=1.5.0", | |||
There was a problem hiding this comment.
Please also update the minimum supported Python's corresponding constraints file to make sure this minimum version continues to be accurate.
Per
python-bigquery-magics/setup.py
Line 114 in 943d0a4
|
FYI: This is what I'd consider a new feature, as it means we support a few more kinds of authentication beyond the ones in the google-auth package. I've updated your PR title accordingly. |
tswast
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47 🦕