Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not set BidiRpc to None when closing it #698

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Nov 6, 2023

For more context see comment #638 (comment).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #638 🦕

@Linchin Linchin requested review from a team as code owners November 6, 2023 18:10
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Nov 6, 2023
@Linchin Linchin enabled auto-merge (squash) November 6, 2023 18:33
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests that would be helpful to validate this, or are they already present?

@Linchin Linchin merged commit 7921561 into googleapis:main Nov 6, 2023
21 checks passed
@Linchin
Copy link
Contributor Author

Linchin commented Nov 6, 2023

I don't think there's a test covering this case. I can create another PR adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

append_rows_stream.close() causes 499 error log
2 participants