Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency python-dateutil in setup.py #1186

Closed
parthea opened this issue Mar 30, 2022 · 0 comments · Fixed by #1187
Closed

Missing dependency python-dateutil in setup.py #1186

parthea opened this issue Mar 30, 2022 · 0 comments · Fixed by #1187
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Mar 30, 2022

I noticed that python-dateutil is missing from setup.py in main. The line "python-dateutil >= 2.7.2, <3.0dev", was removed in 76d88fb.

I'm seeing failures in samples testing for other projects:
https://source.cloud.google.com/results/invocations/8e737a80-a041-468e-a2de-184d5ec1662f/log

******************** TESTING PROJECTS ********************
------------------------------------------------------------
- testing samples/snippets
------------------------------------------------------------
nox > Running session py-3.10
nox > Creating virtual environment (virtualenv) using python3.10 in .nox/py-3-10
nox > python -m pip install -r requirements.txt
nox > python -m pip install -r requirements-test.txt
nox > python -m pip install -e /workspace
nox > pytest --junitxml=sponge_log.xml
ImportError while loading conftest '/workspace/samples/snippets/conftest.py'.
conftest.py:23: in <module>
    from google.cloud import bigquery
.nox/py-3-10/lib/python3.10/site-packages/google/cloud/bigquery/__init__.py:35: in <module>
    from google.cloud.bigquery.client import Client
.nox/py-3-10/lib/python3.10/site-packages/google/cloud/bigquery/client.py:64: in <module>
    from google.cloud.bigquery import _job_helpers
.nox/py-3-10/lib/python3.10/site-packages/google/cloud/bigquery/_job_helpers.py:24: in <module>
    from google.cloud.bigquery import job
.nox/py-3-10/lib/python3.10/site-packages/google/cloud/bigquery/job/__init__.py:17: in <module>
    from google.cloud.bigquery.job.base import _AsyncJob
.nox/py-3-10/lib/python3.10/site-packages/google/cloud/bigquery/job/base.py:27: in <module>
    from google.cloud.bigquery import _helpers
.nox/py-3-10/lib/python3.10/site-packages/google/cloud/bigquery/_helpers.py:24: in <module>
    from dateutil import relativedelta
E   ModuleNotFoundError: No module named 'dateutil'
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Mar 30, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 30, 2022
@parthea parthea added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant