Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): expose date_as_object parameter to users #150

Merged
merged 6 commits into from
Jun 29, 2020
Merged

feat(bigquery): expose date_as_object parameter to users #150

merged 6 commits into from
Jun 29, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #11

@HemangChothani HemangChothani requested a review from plamut June 26, 2020 09:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
plamut
plamut suggested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two doc nits, but more importantly we need an additional test for this new feature when pyarrow is not installed.

google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
tests/unit/test_job.py Show resolved Hide resolved
@plamut plamut changed the title feat(bigquery): expose date_as_object parameter for users feat(bigquery): expose date_as_object parameter to users Jun 26, 2020
plamut
plamut suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just fix the missing parentheses in docstrings.

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
plamut
plamut approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
@plamut plamut merged commit a2d5ce9 into googleapis:master Jun 29, 2020
MaxxleLLC pushed a commit to MaxxleLLC/python-bigquery that referenced this pull request Jun 30, 2020
@HemangChothani
feat(bigquery): expose date_as_object parameter to users (googleapis#150
cbd831e 
)

* feat(bigquery): expose date_as_object parameter for users

* feat(bigquery): nit

* feat(bigquery): add unit test for date as object without pyarrow

* feat(bigquery): docs fixed

* feat(bigquery): nit

* feat(bigquery): nit
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@HemangChothani @abdelmegahedgoogle
feat(bigquery): expose date_as_object parameter to users (googleapis#150
9a90fb1 
)

* feat(bigquery): expose date_as_object parameter for users

* feat(bigquery): nit

* feat(bigquery): add unit test for date as object without pyarrow

* feat(bigquery): docs fixed

* feat(bigquery): nit

* feat(bigquery): nit
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@HemangChothani @abdelmegahedgoogle
feat(bigquery): expose date_as_object parameter to users (googleapis#150
f4900d9 
)

* feat(bigquery): expose date_as_object parameter for users

* feat(bigquery): nit

* feat(bigquery): add unit test for date as object without pyarrow

* feat(bigquery): docs fixed

* feat(bigquery): nit

* feat(bigquery): nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: to_dataframe does not respect date fields
3 participants
@HemangChothani @plamut @googlebot