Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bigquery): consistent use of optional keyword #153

Merged
merged 2 commits into from
Jun 30, 2020
Merged

docs(bigquery): consistent use of optional keyword #153

merged 2 commits into from
Jun 30, 2020
+392 −413

Conversation

HemangChothani
Copy link
Contributor

Fixes #152

@HemangChothani HemangChothani requested a review from plamut June 30, 2020 10:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2020
plamut
plamut suggested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thanks for addressing this!

Found just a few things (capitalization, usages of Optional), and once fixed we can merge this IMO.

google/cloud/bigquery/_pandas_helpers.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
google/cloud/bigquery/model.py Outdated Show resolved Hide resolved
@HemangChothani HemangChothani merged commit 79d8c61 into googleapis:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bigquery: Make consistent use of 'Optional' keyword in docstring
3 participants
@HemangChothani @plamut @googlebot