Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigquery: Model reference repr seems wrong for model_id #65

Closed
HemangChothani opened this issue Mar 24, 2020 · 0 comments · Fixed by #66
Closed

Bigquery: Model reference repr seems wrong for model_id #65

HemangChothani opened this issue Mar 24, 2020 · 0 comments · Fixed by #66
Assignees
@HemangChothani
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@HemangChothani
Copy link
Contributor

For ModelReference's repr use project_id against model_id

python-bigquery/google/cloud/bigquery/model.py

Lines 432 to 435 in be5c8b1

def __repr__(self):
return "ModelReference(project='{}', dataset_id='{}', project_id='{}')".format(
self.project, self.dataset_id, self.model_id
)

@HemangChothani HemangChothani added api: bigquery Issues related to the googleapis/python-bigquery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 24, 2020
@HemangChothani HemangChothani self-assigned this Mar 24, 2020
@HemangChothani HemangChothani mentioned this issue Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bigquery): fix repr of model reference MaxxleLLC/python-bigquery
1 participant
@HemangChothani