Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fix missing attributes in client_options #24

Merged
merged 1 commit into from
Aug 6, 2020
Merged

fix(deps): fix missing attributes in client_options #24

merged 1 commit into from
Aug 6, 2020

Conversation

s22chan
Copy link
Contributor

@s22chan s22chan commented Aug 5, 2020

See #23 (comment)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #23 🦕

This needs corresponding pin fixes on downstream projects such as python-cloud-storage.

@google-cla
Copy link

google-cla bot commented Aug 5, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 5, 2020
@s22chan
Copy link
Contributor Author

s22chan commented Aug 5, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 5, 2020
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing this. Thank you for the PR @s22chan!

@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@busunkim96 busunkim96 changed the title Fix missing scopes attribute in client_options fix(deps): fix missing attributes in client_options Aug 6, 2020
@busunkim96 busunkim96 removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 6, 2020
@busunkim96 busunkim96 merged commit a0e7730 into googleapis:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientOptions object missing attributes
3 participants