Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

docs: fixing upgrading guide v2 #277

Merged
merged 10 commits into from
Jan 10, 2022
Merged

docs: fixing upgrading guide v2 #277

merged 10 commits into from
Jan 10, 2022

Conversation

meredithslota
Copy link
Contributor

Removed formatted tables (reverts #114)
Converted file back to .MD (reverts part of #268)
Fix link to file

Fixes #153 🦕

@meredithslota
docs: reverts the table addition from #114
a1a216a 
Removed formatted tables (reverts #114)
Converted file back to .MD (reverts part of #268)
@meredithslota
docs: revert changes to link
570b635
@meredithslota meredithslota requested a review from a team as a code owner January 4, 2022 20:33
@meredithslota meredithslota changed the title Fixing upgrading guide v2 docs: fixing upgrading guide v2 Jan 4, 2022
@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the googleapis/python-datacatalog API. label Jan 4, 2022
@meredithslota meredithslota requested a review from a team as a code owner January 4, 2022 20:36
@meredithslota meredithslota requested a review from engelke January 4, 2022 20:36
@meredithslota
Copy link
Contributor Author

I do not totally understand why the Owlbot changes got bundled into this PR.

dandhlee
dandhlee approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be that owlbot updates unfroze and trying to put updates in. LGTM for just formatting update though.

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@meredithslota
Copy link
Contributor Author

meredithslota commented Jan 6, 2022 •
edited
Loading

Owlbot changes were merged in a separate PR so we are back down to just formatting changes. :)

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
@meredithslota meredithslota requested review from tswast and removed request for engelke January 7, 2022 22:06
meredithslota
meredithslota commented Jan 7, 2022
View reviewed changes
docs/index.rst Outdated Show resolved Hide resolved
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@parthea parthea mentioned this pull request Jan 8, 2022
Merged
@meredithslota meredithslota merged commit 76f152a into main Jan 10, 2022
@meredithslota meredithslota deleted the fixing-upgrading-guide-v2 branch January 10, 2022 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@parthea parthea parthea approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@tswast tswast

Labels
api: datacatalog Issues related to the googleapis/python-datacatalog API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect rendering of tables in the docs
5 participants
@meredithslota @parthea @dandhlee @tswast @yoshi-kokoro