This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
feat!: add common resource paths; expose client transport; rename type attributes to type_ to avoid name collisions
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
Co-authored-by: Benjamin E. Coe <bencoe@google.com> Source-Author: Takashi Matsuo <tmatsuo@google.com> Source-Date: Tue Sep 1 17:14:08 2020 +0000 Source-Repo: googleapis/synthtool Source-Sha: d91dd8aac77f7a9c5506c238038a26fa4f9e361e Source-Link: googleapis/synthtool@d91dd8a
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: datacatalog
busunkim96
changed the title
type attributes to type_ to avoid name collisions
busunkim96
approved these changes
Nov 17, 2020
| @@ -537,7 +537,7 @@ class Entry(proto.Message): | |||
| Output only when Entry is of type in the EntryType enum. For | |||
| entries with user_specified_type, this field is optional and | |||
| defaults to an empty string. | |||
| type (~.datacatalog.EntryType): | |||
| type_ (~.datacatalog.EntryType): | |||
There was a problem hiding this comment.
Entry.type -> Entry.type_
| @@ -42,7 +42,7 @@ class ColumnSchema(proto.Message): | |||
| Attributes: | |||
| column (str): | |||
| Required. Name of the column. | |||
| type (str): | |||
| type_ (str): | |||
There was a problem hiding this comment.
ColumnSchema.type -> ColumnSchema.type_
| @@ -202,7 +202,7 @@ class TagTemplateField(proto.Message): | |||
| display_name (str): | |||
| The display name for this field. Defaults to | |||
| an empty string. | |||
| type (~.tags.FieldType): | |||
| type_ (~.tags.FieldType): | |||
There was a problem hiding this comment.
TagTemplateField.type -> TagTemplatedField.type_
busunkim96
changed the title
type attributes to type_ to avoid name collisionstype attributes to type_ to avoid name collisions
busunkim96
changed the title
type attributes to type_ to avoid name collisionstype attributes to type_ to avoid name collisions
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/b8e5112c-3774-4b12-81b9-e691b2c52110/targets
Source-Link: googleapis/synthtool@d91dd8a