-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: asyncio microgen client #118
feat: asyncio microgen client #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, a couple questions. Do you have system tests running yet which exercise the async microgen code path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge after addressing @tritone's questions.
@tritone Unfortunately system tests do not exist yet - I was waiting to complete integration of the client before writing system tests, as I feel as though they are dependent on the entire client being converted to async, and it would be preferable to wait until that point. As this code is being committed to |
Discussed offline, I'm okay with merging this code into the branch before system tests are added. |
Resolves #73