Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: scrambles exceptions #251

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: scrambles exceptions #251

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/68aaa8af-44b6-4920-b7df-7f4478f1e87b/targets

  • To automatically regenerate this PR, check this box.

@yoshi-automation
changes without context
c593d2d 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation yoshi-automation requested a review from a team November 11, 2020 13:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 11, 2020
crwilcox
crwilcox reviewed Nov 11, 2020
View reviewed changes
noxfile.py
DEFAULT_PYTHON_VERSION = "3.9"
SYSTEM_TEST_PYTHON_VERSIONS = ["3.9"]
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8", "3.9"]
DEFAULT_PYTHON_VERSION = "3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into updating noxfile template.

tseaver
tseaver suggested changes Nov 12, 2020
View reviewed changes
google/cloud/firestore_admin_v1/services/firestore_admin/async_client.py
exceptions.InternalServerError,
exceptions.ServiceUnavailable,
exceptions.DeadlineExceeded,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crwilcox How is this still happening, given that the googleapis WORKSPACE now uses `gapic-generator-0.35.9.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, PR #252 does not generate this mess.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 12, 2020
@tseaver tseaver changed the title [CHANGE ME] Re-generated to pick up changes from self. DO NOT MERGE: scrambles exceptions Nov 12, 2020
@tseaver tseaver mentioned this pull request Nov 12, 2020
Closed
1 task
tseaver added a commit that referenced this pull request Nov 12, 2020
@tseaver
chore: sort exceptions properly (manual synth)
78d9e18 
- Restore path helper methods to generated clients.
- Enforce that 'request' argument to generated client methods is exclusive
  to flattened arguments.
- Surface 'transport' property for generated clients.

Closes #251
Closes #252
@tseaver tseaver mentioned this pull request Nov 12, 2020
Merged
crwilcox pushed a commit that referenced this pull request Nov 13, 2020
@tseaver
fix: request and flattened params are exclusive, surface transport in…
386e85e 
… generated layer (#256)

- Restore path helper methods to generated clients.
- Enforce that 'request' argument to generated client methods is exclusive
  to flattened arguments.
- Surface 'transport' property for generated clients.

Closes #251
Closes #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@tseaver tseaver tseaver requested changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. context: none do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshi-automation @tseaver @crwilcox