Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add recursive delete #420

Merged
merged 6 commits into from
Aug 16, 2021
Merged

feat: add recursive delete #420

merged 6 commits into from
Aug 16, 2021

Conversation

craiglabenz
Copy link
Contributor

Adds recursive_delete() method which deletes and document or collection and all sub-collections.

@craiglabenz craiglabenz requested a review from a team August 11, 2021 20:36
@craiglabenz craiglabenz requested a review from a team as a code owner August 11, 2021 20:36
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 11, 2021
@google-cla
Copy link

google-cla bot commented Aug 11, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 11, 2021
crwilcox
crwilcox reviewed Aug 11, 2021
View reviewed changes
google/cloud/firestore_v1/async_client.py Show resolved Hide resolved
google/cloud/firestore_v1/async_collection.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/async_query.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/base_document.py Show resolved Hide resolved
google/cloud/firestore_v1/async_client.py Show resolved Hide resolved
google/cloud/firestore_v1/client.py Show resolved Hide resolved
@tseaver
Copy link
Contributor

tseaver commented Aug 12, 2021

Rebasing against current master would clarify this PR, as well as likely appeasing the CLA bot (since the mixed commits are from the merged bulk writer PR).

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 12, 2021
@craiglabenz
Copy link
Contributor Author

As per offline conversations, I think this is ready to go, @crwilcox.

@craiglabenz craiglabenz merged commit 813a57b into master Aug 16, 2021
@craiglabenz craiglabenz deleted the recursive-delete branch August 16, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craiglabenz @tseaver @crwilcox