Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v1): add batch write #62

Merged
merged 27 commits into from
Jul 1, 2020
Merged

feat(v1): add batch write #62

merged 27 commits into from
Jul 1, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/131dd10e-845c-4b68-acf1-3514a23e446f/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@cf2eff0
Source-Link: googleapis/synthtool@db4f15f
Source-Link: googleapis/synthtool@cd522c3
PiperOrigin-RevId: 316514901
Source-Link: googleapis/googleapis@9b170a4
PiperOrigin-RevId: 316182409
Source-Link: googleapis/googleapis@1846617
PiperOrigin-RevId: 316123861
Source-Link: googleapis/googleapis@66f959b
PiperOrigin-RevId: 314471006
Source-Link: googleapis/googleapis@d5fe42c
PiperOrigin-RevId: 314363155
Source-Link: googleapis/googleapis@3a4894c
Source-Link: googleapis/synthtool@4e1d2cb
Source-Link: googleapis/synthtool@e99975b
Source-Link: googleapis/synthtool@ffe1040
Source-Link: googleapis/synthtool@71b8a27
PiperOrigin-RevId: 313460921
Source-Link: googleapis/googleapis@c4e3701
PiperOrigin-RevId: 312689208
Source-Link: googleapis/googleapis@dec3204
PiperOrigin-RevId: 312558019
Source-Link: googleapis/googleapis@a175708
Source-Link: googleapis/synthtool@d2364eb
PiperOrigin-RevId: 312088359
Source-Link: googleapis/googleapis@5a90d46
Source-Link: googleapis/synthtool@fe8bbfd
Source-Link: googleapis/synthtool@7482e79
Source-Link: googleapis/synthtool@09c4846
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e

@yoshi-automation
Integrate Python GAPIC Microgenerator in googleapis. This PR uses usi…
cb95994 
…ng documentai as an example. Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
@yoshi-automation
chore(python): create thread_safety doc
16bc63a 
This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 5 10:06:52 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef
Source-Link: googleapis/synthtool@09c4846
@yoshi-automation
chore(python): remove extra #!/bin/bash
bbfe05e 
Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 12 09:51:12 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 7482e79a82e353248769d819788adc1213e8c207
Source-Link: googleapis/synthtool@7482e79
@yoshi-automation
fix: avoid running out of disk space
9e0307f 
by cleaning up after each inner synth run

Source-Author: Jeffrey Rennie <rennie@google.com>
Source-Date: Fri May 15 10:53:36 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: fe8bbfdf2fef3bed8ebd461dcd33dfdd28604d02
Source-Link: googleapis/synthtool@fe8bbfd
@yoshi-automation
fix: restore GAPIC v2 retry configs
fab3c85 
Restores GAPIC v2 retry config overrides that were
mistakenly removed during migration.

PiperOrigin-RevId: 312088359

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 08:57:12 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c
Source-Link: googleapis/googleapis@5a90d46
@yoshi-automation
chore(python): remove one remaining extra bash line
eb49f04 
To avoid generating bogus PRs

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Carlos de la Guardia <cguardia@yahoo.com>
Source-Date: Tue May 19 11:57:19 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e
Source-Link: googleapis/synthtool@d2364eb
@yoshi-automation
fix: bigtable v2 retry config settings to disable streaming RPC retries
b5557cc 
PiperOrigin-RevId: 312558019

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 20 14:40:11 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: a175708acd7a367ab3ed120fa562331e1761d825
Source-Link: googleapis/googleapis@a175708
@yoshi-automation
Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings.
bcda50a 
PiperOrigin-RevId: 312689208

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 21 10:00:47 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f
Source-Link: googleapis/googleapis@dec3204
@yoshi-automation
bazel: update protobuf, rules_go, gazelle, and gapic-generator-go ver…
86a4621 
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1

PiperOrigin-RevId: 313460921

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 14:10:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c4e37010d74071851ff24121f522e802231ac86e
Source-Link: googleapis/googleapis@c4e3701
@yoshi-automation
docs: update python docs template
5ce88bd 
* docs: update python docs template

* sphinx change

Source-Author: kolea2 <45548808+kolea2@users.noreply.github.com>
Source-Date: Wed May 27 20:44:34 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec
Source-Link: googleapis/synthtool@71b8a27
@yoshi-automation
feat: add templates for python samples projects
0a204c8 
These templates will be used for templates in python-docs-samples
and in Python client libraries. The README generation code is a modified
version of
https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen.

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:39:58 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e
Source-Link: googleapis/synthtool@ffe1040
@yoshi-automation
chore: update default ignores for Python libraries
5d5e7e1 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:43:37 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca
Source-Link: googleapis/synthtool@e99975b
@yoshi-automation
feat: allow custom python versions in noxfile
ccb8004 
Libraries on the microgenerator support a smaller range of Python versions (3.6+).

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 18:22:04 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4e1d2cb79b02d7496b1452f91c518630c207145e
Source-Link: googleapis/synthtool@4e1d2cb
@yoshi-automation
chore: update gapic-generator and go microgen
0f4a5a2 
changes include:
- build_gen: go lro gapic used as dep
- go_gapic_library: fixes shading of go_library importpath

PiperOrigin-RevId: 314363155

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 2 10:56:09 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 3a4894c4f0da3e763aca2c67bd280ae915177450
Source-Link: googleapis/googleapis@3a4894c
@yoshi-automation
firestore: add BatchWrite
cb3b258 
PiperOrigin-RevId: 314471006

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 2 22:32:52 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: d5fe42c39cd35f95131a0267314ae108ab1bef8d
Source-Link: googleapis/googleapis@d5fe42c
@yoshi-automation
chore: set Ruby namespace in proto options
94eddf3 
PiperOrigin-RevId: 316123861

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Jun 12 10:03:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 66f959b51c255dd6bef79ef221865e53a50df878
Source-Link: googleapis/googleapis@66f959b
@yoshi-automation
fix: use protoc-docs-plugin 0.8.0
ac04848 
Fixes issue with missing newline before 'Attributes' in Python docstrings.

PiperOrigin-RevId: 316182409

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Jun 12 14:52:11 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 184661793fbe3b89f2b485c303e7466cef9d21a1
Source-Link: googleapis/googleapis@1846617
@yoshi-automation
feat: retry CommitRequests that fail with UNAVAILABLE
2cc7d45 
PiperOrigin-RevId: 316514901

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Jun 15 12:00:19 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 9b170a4f3beb16f7dab513520a07be48fcb88670
Source-Link: googleapis/googleapis@9b170a4
@yoshi-automation
fix(python): change autodoc_default_flags to autodoc_default_options
2e154a9 
Source-Author: HemangChothani <50404902+HemangChothani@users.noreply.github.com>
Source-Date: Thu Jun 18 22:50:02 2020 +0530
Source-Repo: googleapis/synthtool
Source-Sha: cd522c3b4dde821766d95c80ae5aeb43d7a41170
Source-Link: googleapis/synthtool@cd522c3
@yoshi-automation
feat(python): add defaults for microgenerator libraries
ca5423f 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Mon Jun 22 17:56:27 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: db4f15fedc76e04018e6e43ec403e804e1142158
Source-Link: googleapis/synthtool@db4f15f
@yoshi-automation
chore(python): fix line breaks in template and use newer black version
86abc9b 
* chore(python): fix line breaks in template

* fix: also update black version

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue Jun 23 02:33:35 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: cf2eff09d0f5319a4dc5cdce2b6356d85af4a798
Source-Link: googleapis/synthtool@cf2eff0
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2020
busunkim96
busunkim96 reviewed Jul 1, 2020
View reviewed changes
google/cloud/firestore_admin_v1/gapic/firestore_admin_client.py
@@ -84,44 +87,44 @@ def from_service_account_file(cls, filename, *args, **kwargs):
from_service_account_json = from_service_account_file

@classmethod
def database_path(cls, project, database):
"""Return a fully-qualified database string."""
def collection_group_path(cls, project, database, collection):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly added

google/cloud/firestore_admin_v1/gapic/firestore_admin_client.py
)

@classmethod
def field_path(cls, project, database, collection_id, field_id):
"""Return a fully-qualified field string."""
def database_path(cls, project, database):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unchanged

google/cloud/firestore_admin_v1/gapic/firestore_admin_client.py
)

@classmethod
def index_path(cls, project, database, collection_id, index_id):
"""Return a fully-qualified index string."""
def field_path(cls, project, database, collection, field):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unchanged

google/cloud/firestore_admin_v1/gapic/firestore_admin_client.py
)

@classmethod
def parent_path(cls, project, database, collection_id):
"""Return a fully-qualified parent string."""
def index_path(cls, project, database, collection, index):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unchanged

google/cloud/firestore_admin_v1/gapic/firestore_admin_client.py
@@ -84,44 +87,44 @@ def from_service_account_file(cls, filename, *args, **kwargs):
from_service_account_json = from_service_account_file

@classmethod
def database_path(cls, project, database):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

google/cloud/firestore_v1/gapic/firestore_client.py
@@ -570,7 +530,7 @@ def create_document(
def update_document(
self,
document,
update_mask,
update_mask=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK as the order is unchanging.

google/cloud/firestore_v1/gapic/firestore_client.py
@@ -752,7 +711,7 @@ def delete_document(
def batch_get_documents(
self,
database,
documents,
documents=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK as the order is not changed.

google/cloud/firestore_v1/gapic/firestore_client.py
@@ -952,7 +910,7 @@ def begin_transaction(
def commit(
self,
database,
writes,
writes=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK as the order is unchanged

google/cloud/firestore_v1/gapic/firestore_client.py
@@ -1450,3 +1407,227 @@ def list_collection_ids(
response_token_field="next_page_token",
)
return iterator

def partition_query(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New method

google/cloud/firestore_v1/gapic/firestore_client.py Outdated
)
return iterator

def batch_write(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New method

@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. feat: add batch write to v1 Jul 1, 2020
@busunkim96 busunkim96 changed the title feat: add batch write to v1 feat(v1): add batch write Jul 1, 2020
@busunkim96 busunkim96 merged commit 1415bc4 into master Jul 1, 2020
@busunkim96 busunkim96 deleted the autosynth branch July 1, 2020 21:59
@tseaver
Copy link
Contributor

tseaver commented Aug 20, 2020

Changes in this PR seem to be pulled into the formerly-v2-staging branch in #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @busunkim96 @googlebot