Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix typehint on AsyncDocumentReference.get() #649

Merged
merged 4 commits into from
Nov 10, 2022
Merged

fix: Fix typehint on AsyncDocumentReference.get() #649

merged 4 commits into from
Nov 10, 2022

Conversation

jyasskin
Copy link
Contributor

@jyasskin jyasskin commented Oct 7, 2022 •
edited by Mariatta
Loading

Neither of the return statements is a call to an async function.

Fixes #627

@jyasskin jyasskin requested review from a team as code owners October 7, 2022 04:59
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Oct 7, 2022
@Mariatta Mariatta changed the title AsyncDocumentReference.get() only returns 1 level of coroutine. fix: Fix typehint on AsyncDocumentReference.get() Nov 10, 2022
@Mariatta
Copy link
Contributor

Thanks for the PR! This will fix issue #627

There were lint errors due to unused imports. Can you please address those?

Mariatta
Mariatta suggested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused imports so lint will pass.

@jyasskin jyasskin requested a review from Mariatta November 10, 2022 02:58
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 10, 2022
@Mariatta Mariatta merged commit a8d79c8 into googleapis:main Nov 10, 2022
@Mariatta
Copy link
Contributor

Thanks!

@release-please release-please bot mentioned this pull request Nov 10, 2022
Merged
@jyasskin jyasskin deleted the patch-1 branch November 10, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect typing on AsyncDocumentReference.get
2 participants
@jyasskin @Mariatta