-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for custom JSON encoders #657
feat: Add support for custom JSON encoders #657
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
84dd13f
to
302491d
Compare
302491d
to
f9fc491
Compare
Thanks for putting this together. My only hesitation is that the That said, I'm not seeing a clear solution for I opened a feature request to look into this in the future, but I don't think it needs to block merging this |
Add the ability to provide custom
JSONEncoder
classes toStructuredLogHandler
, so the log caller doesn't have to convert to primitive types every time a log record is createdFixes #656 🦕