proto-plus >= 1.25 needed for python 3.13

[johncarter-phntm]

Environment details

• OS type and version: Debian Bookworm / Docker
• Python version: python --version 3.13.0
• pip version: pip --version 24.2
• google-cloud-logging version: pip show google-cloud-logging

Name: google-cloud-logging
Version: 3.11.2
Summary: Stackdriver Logging API client library
Home-page: https://github.com/googleapis/python-logging
Author: Google LLC
Author-email: googleapis-packages@google.com
License: Apache 2.0
Location: /usr/local/lib/python3.13/site-packages
Requires: google-api-core, google-auth, google-cloud-appengine-logging, google-cloud-audit-log, google-cloud-core, grpc-google-iam-v1, opentelemetry-api, proto-plus, protobuf
Required-by: 

Steps to reproduce

1. docker run -it python:3.13.0 bash
2. pip install google-cloud-logging
3. python -c "import google.cloud.logging"

Code example

import google.cloud.logging

Stack trace

Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import google.cloud.logging
  File "/usr/local/lib/python3.13/site-packages/google/cloud/logging/__init__.py", line 18, in <module>
    from google.cloud.logging_v2 import __version__
  File "/usr/local/lib/python3.13/site-packages/google/cloud/logging_v2/__init__.py", line 21, in <module>
    from google.cloud.logging_v2.client import Client
  File "/usr/local/lib/python3.13/site-packages/google/cloud/logging_v2/client.py", line 25, in <module>
    from google.cloud.logging_v2._helpers import _add_defaults_to_filter
  File "/usr/local/lib/python3.13/site-packages/google/cloud/logging_v2/_helpers.py", line 31, in <module>
    from google.cloud.logging_v2.types import LogSeverity
  File "/usr/local/lib/python3.13/site-packages/google/cloud/logging_v2/types/__init__.py", line 36, in <module>
    from .logging_config import (
    ...<53 lines>...
    )
  File "/usr/local/lib/python3.13/site-packages/google/cloud/logging_v2/types/logging_config.py", line 2403, in <module>
    class LocationMetadata(proto.Message):
    ...<11 lines>...
        )
  File "/usr/local/lib/python3.13/site-packages/proto/message.py", line 279, in __new__
    file_info.generate_file_pb(new_class=cls, fallback_salt=full_name)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/proto/_file_info.py", line 104, in generate_file_pb
    pool.Add(self.descriptor)
    ~~~~~~~~^^^^^^^^^^^^^^^^^
TypeError: Couldn't build proto file into descriptor pool: duplicate symbol 'google.logging.v2.__firstlineno__'

[cdce8p]

This is probably related to googleapis/proto-plus-python#490

[johncarter-phntm]

This is probably related to googleapis/proto-plus-python#490

Agreed - proto-plus>=1.25.0rc0 seems to fix the issue for me 👍

[parthea]

The setup.py file should be updated to require proto-plus >= 1.25 for python_version >=3.13 due to googleapis/proto-plus-python#490

See release notes here: https://github.com/googleapis/proto-plus-python/releases/tag/v1.25.0

Add "proto-plus >= 1.25.0, <2.0.0dev; python_version>='3.13'", after the following line

python-logging/setup.py

Line 49 in 55d038f

"proto-plus >= 1.22.2, <2.0.0dev; python_version>='3.11'",

As an example, see googleapis/python-api-core#740