Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update_subscription and update_snapshot examples are wrong #110

Closed
pradn opened this issue May 29, 2020 · 0 comments · Fixed by #113
Closed

docs: update_subscription and update_snapshot examples are wrong #110

pradn opened this issue May 29, 2020 · 0 comments · Fixed by #113
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.

Comments

@pradn
Copy link
Contributor

pradn commented May 29, 2020 •
edited
Loading

The example subscription object doesn't have a 'name' field. Same with update_snapshot.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label May 29, 2020
@pradn pradn changed the title docs: update_subscription example is wrong docs: update_subscription and update_snapshot examples are wrong May 29, 2020
@pradn pradn mentioned this issue May 30, 2020
Closed
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels May 30, 2020
@meredithslota meredithslota added type: docs Improvement to the documentation for an API. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 3, 2020
@plamut plamut self-assigned this Jun 5, 2020
@plamut plamut mentioned this issue Jun 5, 2020
Merged
4 tasks
@pradn pradn closed this as completed in #113 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix update subscription/snapshot/topic samples plamut/python-pubsub
4 participants
@pradn @plamut @meredithslota @yoshi-automation