-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default deadline for publish does not match expectations #303
Default deadline for publish does not match expectations #303
Comments
I'll check the logs to see how many requests are actually made, and where the total deadline comes from. |
This is the current output with logging level set to DEBUG and the log format slightly adjusted from my machine, with internet accidentally enabled (it appears I was nevertheless lucky with a transient error):
Retries work as expected, but the total deadline is indeed 120.0 seconds. |
Retries are performed by It's true that in the code that wraps API methods, a While we could patch this in the client library, it's cleaner to update the generator. Update: Created a gapic generator issue to track this. |
Does this mean that none of the retry properties one passes in when publishing are taking effect for any publish calls and we are always just using the defaults? |
Nevermind, I ran an experiment and custom retry settings do take effect as expected. |
Yeah, it's only the default timeout when nothing custom is specified. 👍 Since it seems to only require a template change, I will probably just submit the fix to the generator myself. @kamalaboulhosn Presumably the same default timeout (60 seconds) should appliy to subscriber methods as well? I can check that, too, while at it. Update: Generator PR, when merged, an autosynth PR will presumably follow in this repo. |
Will keep this open until an autosynth PR re-generates the GAPIC library with the generator fix that has now been merged. |
The default total deadline for publish operations is supposed to be 60 seconds. However, it actually seems to be 120 seconds. It is easy to test this by starting up python and running the following with internet disabled:
This should exit after 60 seconds. However, it actually exits after 120 seconds with an error as follows:
Where are the default retry settings coming from and what are they? Want to confirm that we are trying requests more than once by default.
The text was updated successfully, but these errors were encountered: