Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The test tests.system.test_streaming_pull_blocking_shutdown is flaky #372

Closed
plamut opened this issue Apr 7, 2021 · 1 comment · Fixed by #378
Closed

The test tests.system.test_streaming_pull_blocking_shutdown is flaky #372

plamut opened this issue Apr 7, 2021 · 1 comment · Fixed by #378
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@plamut
Copy link
Contributor

plamut commented Apr 7, 2021

There are rumours that this test is flaky, although I have not been able to verify that myself on my machine. It nevertheless warrants an investigation.
@plamut plamut added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. testing labels Apr 7, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 7, 2021
@plamut plamut mentioned this issue Apr 7, 2021
Merged
4 tasks
@plamut
Copy link
Contributor Author

plamut commented Apr 7, 2021 •
edited
Loading

@jimfulton I presume the failing system test is this one? Is it consistently failing for you? Do you run it individually or the entire system test suite?

(asking b/c it consistently passes on my machine, and I also don't remember seeing it fail on CI)

Edit: Found a failed instance on Jim's PR from yesterday. It looks as if ACK requests were not sent for the received messages that were being processed at the time of shutdown (the client should have received only 7 of them).

Edit 2
It appears that the test fails (more often?) locally if run within the entire test suite, but not if ran individually. I was able to reproduce the failure that way.

@plamut plamut self-assigned this Apr 7, 2021
@plamut plamut mentioned this issue Apr 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test for blocking pull shutdown plamut/python-pubsub
1 participant
@plamut