Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is_reset_signal should handle status that is None #183

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jul 13, 2021

When trailing_metadata is None, rpc_status.from_call() returns None. This needs to be handled when detecting the RESET signal.

@tmdiep tmdiep requested a review from dpcollins-google July 13, 2021 23:24
@tmdiep tmdiep requested review from a team as code owners July 13, 2021 23:24
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Jul 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2021
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2021
Copy link

@manuelmenzella-google manuelmenzella-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@tmdiep tmdiep merged commit 4ba484e into googleapis:master Jul 13, 2021
@tmdiep tmdiep deleted the fix_reset_null branch July 13, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants