Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cursor must detect if the parent connection is closed #463

Merged
merged 17 commits into from
Sep 1, 2020
Merged

feat: cursor must detect if the parent connection is closed #463

merged 17 commits into from
Sep 1, 2020

Conversation

IlyaFaer
Copy link
Contributor

Closes #461

@IlyaFaer IlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: spanner Issues related to the googleapis/python-spanner-django API. labels Aug 24, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2020
@IlyaFaer
Copy link
Contributor Author

This PR is based on changes from connect() refactoring changes, so it should be merged after "connect() refactoring" PR

@IlyaFaer IlyaFaer marked this pull request as ready for review August 24, 2020 09:58
@IlyaFaer IlyaFaer requested a review from c24t August 24, 2020 09:58
@IlyaFaer IlyaFaer mentioned this pull request Aug 24, 2020
Closed
c24t
c24t reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I'll review again after #462 gets merged.

c24t
c24t reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, but @IlyaFaer I'll wait until you respond to approve so we don't automatically merge this before it's ready.

spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
spanner_dbapi/cursor.py Show resolved Hide resolved
tests/spanner_dbapi/test_cursor.py Show resolved Hide resolved
@c24t
Copy link
Contributor

c24t commented Aug 28, 2020

Seeing more of these in CI:

panic: rpc error: code = ResourceExhausted desc = Project 1065521786570 cannot add 1 nodes in region us-west1.

Hopefully to be fixed in #471.

IlyaFaer
IlyaFaer commented Aug 28, 2020
View reviewed changes
Copy link
Contributor Author

@IlyaFaer IlyaFaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added few more docstrings/renaming changes

spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
tests/spanner_dbapi/test_cursor.py Show resolved Hide resolved
@c24t c24t merged commit 6028f88 into googleapis:master Sep 1, 2020
@IlyaFaer IlyaFaer deleted the is_closed_attribute branch September 2, 2020 07:37
c24t pushed a commit that referenced this pull request Sep 15, 2020
@c24t
feat: cursor must detect if the parent connection is closed (#463)
a9fd5a3
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection.close() doesn't close cursors
2 participants
@IlyaFaer @c24t