Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Executing existing DDL statements on executemany statement execution #1032

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

ankiaga
Copy link
Contributor

@ankiaga ankiaga commented Nov 8, 2023

@ankiaga ankiaga requested review from a team as code owners November 8, 2023 09:07
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Nov 8, 2023
@ankiaga ankiaga changed the title Executing existing DDL statements on executemany statement execution fix: Executing existing DDL statements on executemany statement execution Nov 8, 2023
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

google/cloud/spanner_dbapi/cursor.py Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 9, 2023
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with some nits on formatting

tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
@olavloite olavloite merged commit 07fbc45 into googleapis:main Nov 17, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants