Feat: Add "auto" checksum option and make default #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
andrewsg
force-pushed
the
3.0-checksum-defaults
branch
from
7c76ff3 to
a82d9b8
Compare
andrewsg
force-pushed
the
3.0-checksum-defaults
branch
from
a82d9b8 to
25e1109
Compare
cojenco
approved these changes
Nov 20, 2024
| downloads and None for most uploads. Note that ranged downloads ("start" or | ||
| "end" set) still do not support any checksumming, and some features in | ||
| `transfer_manager.py` still support crc32c only. | ||
|
|
There was a problem hiding this comment.
Thanks for adding this! This will make 3.0 release notes really clear
| if self.checksum == "auto": | ||
| self.checksum = ( | ||
| "crc32c" if _helpers._is_crc32c_available_and_fast() else "md5" | ||
| ) |
There was a problem hiding this comment.
I like how this is handled in the constructor 🎉
| @@ -191,7 +191,7 @@ def test_constructor_defaults(self): | |||
| upload = _upload.MultipartUpload(MULTIPART_URL) | |||
| assert upload.upload_url == MULTIPART_URL | |||
| assert upload._headers == {} | |||
| assert upload._checksum_type is None | |||
| assert upload._checksum_type == "crc32c" # converted from "auto" | |||
| @@ -62,7 +64,7 @@ class CorruptingAuthorizedSession(tr_requests.AuthorizedSession): | |||
| """ | |||
|
|
|||
| EMPTY_MD5 = base64.b64encode(hashlib.md5(b"").digest()).decode("utf-8") | |||
| crc32c = _helpers._get_crc32c_object() | |||
| crc32c = google_crc32c.Checksum() | |||
There was a problem hiding this comment.
For system tests, maybe we can add a parametrized checksum "auto" here?
python-storage/tests/resumable_media/system/requests/test_download.py
Lines 272 to 273 in d17a15d
Can do the same for an upload integration test here as well
python-storage/tests/resumable_media/system/requests/test_upload.py
Lines 234 to 235 in d17a15d
andrewsg
force-pushed
the
3.0-checksum-defaults
branch
from
b2bb316 to
c4201c6
Compare
andrewsg
added a commit
that referenced
this pull request
Dec 5, 2024
andrewsg
added a commit
that referenced
this pull request
Dec 10, 2024
andrewsg
added a commit
that referenced
this pull request
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.